Merge pull request #6 from dimasmds/2.0.5

2.0.5
dimasmds · Dec 20, 2021 · c927426 · c927426
2 parents bdb2346 + 9d8e821
commit c927426
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/README.id-ID.md b/README.id-ID.md
@@ -229,7 +229,7 @@ container.register({ Class: Engine });
 
 ### container.destroyInstance(key)
 Setiap class yang didaftarkan diakses, ia akan membuat instance di dalam properti `container.instances[key].INSTANCE`.
-Fungsi `container.deleteInstance(key)` digunakan untuk menghapus instance dari class untuk menghapus ruang penggunaan memory.
+Fungsi `container.destroyInstance(key)` digunakan untuk menghapus instance dari class untuk menghapus ruang penggunaan memory.
 
 Example:
 

diff --git a/src/Container.ts b/src/Container.ts
@@ -44,7 +44,7 @@ export class Container {
 
   private static verifyParameterOption(optionParameter: ParameterOption) {
     if (typeof optionParameter !== 'object' || Array.isArray(optionParameter)) {
-      throw new Error('parameter should be a parameter option object');
+      throw new Error('parameter should be a ParameterOption object');
     }
 
     const keys = Object.keys(optionParameter);
@@ -80,15 +80,15 @@ export class Container {
 
     dependencies.forEach((dependency) => {
       if (typeof dependency !== 'object' || Array.isArray(dependency)) {
-        throw new Error('dependencies item should be a dependency object');
+        throw new Error('dependencies item should be a Dependency object');
       }
 
       const keys = Object.keys(dependency);
       const allowedProps = ['name', 'concrete', 'internal'];
       const unknownProps = keys.filter((key) => !allowedProps.includes(key));
 
       if (unknownProps.length) {
-        throw new Error(`${unknownProps.join(', ')} is not allowed in dependency object`);
+        throw new Error(`${unknownProps.join(', ')} is not allowed in Dependency object`);
       }
 
       if (!dependency.name) {
@@ -172,7 +172,7 @@ export class Container {
     const instance = this.instances[key];
 
     if (!instance) {
-      throw new Error('instance not found');
+      throw new Error(`${key} instance not found`);
     }
 
     if (instance.INSTANCE instanceof instance.Class) {
@@ -188,7 +188,7 @@ export class Container {
 
   public destroyInstance(key: string) {
     if (!this.instances[key]) {
-      throw new Error('not found instance to be destroy');
+      throw new Error(`Cannot destroy instance with key ${key}. Because it is not exist`);
     }
 
     delete this.instances[key].INSTANCE;

diff --git a/src/__test__/Container.test.ts b/src/__test__/Container.test.ts
@@ -68,7 +68,7 @@ describe('Container', () => {
           },
         ];
 
-        expect(() => new Container(instanceOptions)).toThrowError('parameter should be a parameter option object');
+        expect(() => new Container(instanceOptions)).toThrowError('parameter should be a ParameterOption object');
       });
 
       it('should throw error when parameter is contain unknown property', () => {
@@ -131,7 +131,7 @@ describe('Container', () => {
               },
             ];
 
-            expect(() => new Container(instanceOptions)).toThrowError('dependencies item should be a dependency object');
+            expect(() => new Container(instanceOptions)).toThrowError('dependencies item should be a Dependency object');
           });
 
           it('should throw error when dependency is contain unknown property', () => {
@@ -153,7 +153,7 @@ describe('Container', () => {
               },
             ];
 
-            expect(() => new Container(instanceOptions)).toThrowError('unknownA, unknownB is not allowed in dependency object');
+            expect(() => new Container(instanceOptions)).toThrowError('unknownA, unknownB is not allowed in Dependency object');
           });
 
           it('should throw error when dependency is not contain name property', () => {
@@ -635,7 +635,7 @@ describe('Container', () => {
 
     it('should throw error when instance not found', () => {
       expect(() => container.getInstance('abc'))
-        .toThrowError('instance not found');
+        .toThrow('abc instance not found');
     });
 
     it('should only create one instance (singleton)', () => {
@@ -683,7 +683,7 @@ describe('Container', () => {
 
     it('should throw error when instance is not found', () => {
       expect(() => container.destroyInstance('not_found'))
-        .toThrowError('not found instance to be destroy');
+        .toThrowError('Cannot destroy instance with key not_found. Because it is not exist');
     });
 
     it('should delete active instance correctly', () => {