Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change status text by setting? #28

Open
mathomp4 opened this issue Sep 6, 2019 · 0 comments
Open

Change status text by setting? #28

mathomp4 opened this issue Sep 6, 2019 · 0 comments

Comments

@mathomp4
Copy link

mathomp4 commented Sep 6, 2019

After you fixed my issue #26, we are now testing out using required labels in our system. Huzzah!

But now I have a question for the devels. Would it be possible to have the status text on github, which I controlled by, I think:

required-labels/utils.py

Lines 46 to 51 in 0fddb9c

def create_status_json(self, required_any, required_all, banned):
passes_label_requirements = self.validate_labels(required_any, required_all, banned)
if passes_label_requirements:
description = "Label requirements satisfied."
else:
description = "Label requirements not satisfied."

be dynamic and changeable in the Heroku settings? It would be nice if the check returns a failure that it could say:

Label requirements not satisfied: You must add at least one of label1, label2, label3

where the label1, etc. are the required-any labels (or whatever) we've decided to be required.

Now, I'm going to add a PR template explaining this so they know they need a label, but as is well known, if a template has comments, they can be easily ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant