Possibly replace required-labels?

[mathomp4]

A query for the dev. Do you think this action could (eventually) replace my reliance on https://github.com/dimagi/required-labels If there's a way to use Github Actions instead of Heroku, it sounds like a good thing to me.

But, am I right in my reading that this doesn't yet have all the same functionality?

[yogevbd]

It does have the same functionality now 😊.
You can easily move to Github Actions by adding the yml file as described in the Readme file.
Let me know if you encounter issues or missing functionality. Thanks!

[mathomp4]

@yogevbd Ooh. Nice. Thanks. I'll try it out. There might be some more thoughts coming maybe based on this: dimagi/required-labels#28 (i.e., some way to tell people they should add a label x, y, z...)

But until then, I think I'm stupid/newbie. I'm trying it out here but it doesn't seem to mind I don't have any labels: mathomp4/labeltest-github-actions#2

[yogevbd]

The readme file was misleading.. sorry for the inconvenience.
Created a pull request in mathomp4/labeltest-github-actions#3 with the fix.
And it's defiantly possible and easy to add description labels.. will add it soon.

[yogevbd]

Added check run failure description support. See the updated Readme file.

[mathomp4]

@yogevbd Sorry for being out of touch on this. Work has been...worky. But I'm back on it. I tried updating my .github/workflows/enforce-labels.yml but I seem to have broken something. When I made a test PR at mathomp4/labeltest-github-actions#4 it's happy with no labels at all.

Any ideas what I might have done wrong?

[yogevbd]

The syntax was wrong. I suggested a fix in mathomp4/labeltest-github-actions#5

[mathomp4]

Well I feel stupid. I kept staring at the complex stuff below.

It does work! I wish there was a good way to see the "You need different flags" text on the PR page rather than having to drill down into the Actions tab. Not sure why github can't just make that bit of the "Review required" box bigger! or expandable.

But, if do go to the Checks tab I do see in the run step:

##[error]Select at least one label ['bug','enhancement','wontfix']
##[error]Select at least one label ['required']

Woot!

(Though, I've always wondered how GitGuardian gets that nice pretty page. My guess: money 😄 )

[mathomp4]

As I try to clean up, I can definitely say @yogevbd helped me out with this. I will close.

Though fair warning to @yogevbd, I am looking at label actions again... 😄