Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Created field to images command #1653

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bramalho
Copy link

@bramalho bramalho commented Feb 4, 2025

In this PR we are adding the field Created to doctl images command. This is useful for us to manage our images/snapshots available for the autoscale group. Once this field is available in godo and DO API.

@loosla loosla self-assigned this Feb 4, 2025
@loosla
Copy link
Contributor

loosla commented Feb 4, 2025

👋 Hey Bruno,
Thanks for an awesome change 🚀
Let's fix the integration tests and it should be good to go.

You can run integration tests with
doctl$ make test_integration

The changes like this
Screenshot from 2025-02-04 14-26-30
are needed in the files:
integration/droplet_backups_test.go
integration/droplet_snapshots_test.go
integration/image_create_test.go
integration/image_get_test.go
integration/image_list_application_test.go
integration/image_list_test.go

Feel free to add
"created_at": "2020-07-28T16:47:44Z" in a response in integration/droplet_backups_test.go and integration/droplet_snapshots_test.go. Here is the example.
Screenshot from 2025-02-04 14-30-13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants