Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: upgrade to 1.22 #1558

Merged
merged 2 commits into from
Jul 24, 2024
Merged

go: upgrade to 1.22 #1558

merged 2 commits into from
Jul 24, 2024

Conversation

bentranter
Copy link
Member

Upgrades the GitHub CI workflows and go.mod entry for Go 1.22. Just in time for Go 1.23 to be released 😅

Copy link

gitguardian bot commented Jul 24, 2024

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9440732 Triggered PostgreSQL Credentials 0d06b94 integration/database_connection_pool_test.go View secret
9440732 Triggered PostgreSQL Credentials 0d06b94 integration/database_connection_pool_test.go View secret
9440732 Triggered PostgreSQL Credentials 0d06b94 integration/database_connection_pool_test.go View secret
9440732 Triggered PostgreSQL Credentials 0d06b94 integration/database_connection_pool_test.go View secret
9440732 Triggered PostgreSQL Credentials 0d06b94 integration/database_connection_pool_test.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@bentranter
Copy link
Member Author

When I click the GitGuardian ID it says, "not found", so I'm guessing this is getting falsely flagged from the change in #1557 prior to it being marked as a test value. Going to merge as-is and see if it's fine.

@bentranter bentranter merged commit 6d7019a into main Jul 24, 2024
7 of 8 checks passed
@bentranter bentranter deleted the bentranter/upgrade-go-version branch July 24, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants