Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizing documentation on organization variables #9

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

cjscheller
Copy link
Contributor

@cjscheller cjscheller commented Feb 22, 2022

Adds support for creating documentation site for other organizations via variables defined in _config.yml.

@Xavbm Thanks for helping me get this far. Running into one more issues that I'm hoping you can help me with:

  • I am attempting to dynamically render a document/file by setting a boolean configuration variable to the published (based on the Jekyll docs). However, I am not able to tell if A) the configuration variable is even being rendered correctly in this Front Matter and B) if the string is correctly parsed as a boolean to set published as needed. Here's an example. Any thoughts?

@cjscheller cjscheller requested a review from Xavbm February 22, 2022 23:08
@netlify
Copy link

netlify bot commented Feb 22, 2022

Deploy Preview for amazing-darwin-824daa ready!

Name Link
🔨 Latest commit 0684eba
🔍 Latest deploy log https://app.netlify.com/sites/amazing-darwin-824daa/deploys/625d920fc176b4000819c7bb
😎 Deploy Preview https://deploy-preview-9--amazing-darwin-824daa.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Xavbm
Copy link
Contributor

Xavbm commented Feb 24, 2022

@cjscheller , It look like the same "problem" as getting the values from _config.yml, we can't directly use site variables in the markdown file. I hope the published value can be overrided before it is used to generate the html. I will take a look!

@Xavbm
Copy link
Contributor

Xavbm commented Mar 1, 2022

@cjscheller Hi Carl! Thank you for your patience, I've had a busy week and weekend. I have not found a way to edit all Published flags from from _config.yml so I opened a thread on their repo. I hope to have a feedback soon and be able to help you. Is this an irritant or a blocker?

@cjscheller
Copy link
Contributor Author

@Xavbm No worries at all, has been a busy time for me as well. Thanks for following up and opening a thread.

Not a blocker for me, as I have created a separate branch off of this one that hardcodes the published values where necessary. We'll wait to see what their response is.

Feel free to drop a link to the thread here so we can track it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants