fix: improve peer discovery #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanHahn
commented
Apr 11, 2024
EvanHahn
added a commit
to digidem/comapeo-core
that referenced
this pull request
Apr 11, 2024
See also: <digidem/comapeo-mobile#245>. Our peer discovery system is unreliable on some networks. We'd like to replace it with [a native local service discovery system][0]. To do this, the frontend needs to tell the backend about peers it finds. In other words, we need to "invert" peer discovery. Here's pseudocode for what the frontend needs to do: const {name, port} = await mapeoApi.startLocalPeerDiscoveryServer() zeroconf.publishService({name, port}) zeroconf.on('resolved', (peer) => { mapeoApi.connectPeer(peer) }) This implements that by removing our mDNS system and replacing it with these public APIs. Closes [#474][1]. [0]: https://www.npmjs.com/package/react-native-zeroconf [1]: #474
achou11
reviewed
Apr 11, 2024
There was a problem hiding this comment.
overall changes make sense and seems to work as expected when testing with a couple of devices (+ Wireshark)
although i think this is handled by the inclusion of other network-related deps, to be safe, may be worth updating the AndroidManifest.xml file with what the zeroconf dependency requires:
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
<uses-permission android:name="android.permission.ACCESS_WIFI_STATE" />
<uses-permission android:name="android.permission.CHANGE_WIFI_MULTICAST_STATE" />
Ping me for another review when core is updated!
|
Added the Android permissions in e4bf013. I'll let you know when I've updated |
|
I think this is all ready to go! |
achou11
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on digidem/comapeo-core#550.I recommend reviewing this one commit at a time.
Our peer discovery system is unreliable on some networks. This replaces it with a native local service discovery system where we tell
@mapeo/coreabout the peers we find.Closes digidem/comapeo-core#474.