-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: LineString and MultiLineString types #17
Conversation
This adds support for [LineString] and [MultiLineString] geometry object types. [LineString]: https://datatracker.ietf.org/doc/html/rfc7946#section-3.1.4 [MultiLineString]: https://datatracker.ietf.org/doc/html/rfc7946#section-3.1.5
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good apart from a consistency question. For better-or-worse we omit lengths
for Polygons and MultiPolygons when there is only one ring / polygon (see
Line 156 in f259310
lengths = lengths.length === 0 ? [rawCoords.length / 2] : lengths |
Done in e8c1dc1. Tried to match what Geobuf does in this case. I also added some additional fixtures in cab67c0 to improve my confidence that this works. |
This adds support for LineString and MultiLineString geometry object types.