Skip to content

Commit

Permalink
chore: update CI Node versions and remove Node 22 support (#5)
Browse files Browse the repository at this point in the history
* chore: update CI to run on active Node versions

* fix: fix test script

This was failing in Node v22 maybe because of a syntax change

* chore: remove Node 22 support

Tests were failing on Node 22. Easiest solution is probably to wait until we update to ts-proto@2 on mapeo-schema, so we can update here too, which switches to use @bufbuild/protobuf which should better support Node 22
  • Loading branch information
gmaclennan authored Sep 4, 2024
1 parent ba0d0a0 commit c0c43fc
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
6 changes: 5 additions & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,18 @@ jobs:
test:
runs-on: ubuntu-latest

strategy:
matrix:
node-version: [18, 20]

steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: '20'
node-version: ${{ matrix.node-version }}

- name: Install dependencies
run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
22
20
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"lint": "npm-run-all --parallel lint:*",
"prepack": "npm run build",
"pretest": "npm run build",
"test": "c8 --100 --exclude 'dist/proto/*' node --test test",
"test": "c8 --100 --exclude 'dist/proto/*' node --test",
"posttest": "c8 report --reporter=text-lcov > ./coverage/lcov.info",
"prepare": "husky"
},
Expand Down

0 comments on commit c0c43fc

Please sign in to comment.