chore: remove manual type definitions for DataType #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanHahn
commented
Oct 30, 2024
| } | ||
|
|
||
| /** | ||
| * @param {MapeoDoc} doc | ||
| * @param {any} doc |
There was a problem hiding this comment.
I was unable to figure out how to get this to type-check without any, much to my dismay.
*This change should have no user impact.* Before this change, DataType had its own type definitions in `src/datatype/index.d.ts`. This removes that file. I tested this by manually including it in CoMapeo Mobile and it type- checked fine. I think this is a useful cleanup on its own, but I believe it will make a future improvement easier.
EvanHahn
force-pushed
the
datatype-type-simplification
branch
from
7ef13c1 to
766f45f
Compare
gmaclennan
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should have no user impact.
Before this change, DataType had its own type definitions in
src/datatype/index.d.ts. This removes that file.I tested this by manually including it in CoMapeo Mobile and it type-checked fine.