Invert "does this entry match the filter" logic #947
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged into #940.
Before this change, we turned filters into a list of path prefixes and then checked entry paths against those prefixes. Rough pseudocode:
For performance and simplicity, I think it's cleaner if we "look up" entry paths in the existing filter object. Rough pseudocode:
I think this has two advantages:
/photos/original
versus/photos/
). We don't need to worry about sketchy paths (e.g.,/photos/garbage/../original
).Set
.)