chore: change lockfile bot to update comments #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achou11
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
based on the docs, this should be configured to update the comment by default which is why i didn't specify it 🤦♂️
https://github.com/rvanvelzen/npm-lockfile-changes?tab=readme-ov-file#-inputs
another lesson in preferring to be explicit when configuring stuff like this...
|
yeah looks like a bug in their |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposed change is to the lockfile bot which comments on pull requests with changes to the lockfile. I propose changing the bot config to update the original comment when the PR is updated, rather than creating new comments, in order to reduce "noise" in the PR comment thread. Open to arguments for keeping it as-is with new comments for each commit!