Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add another branch filter for release workflow #858

Closed
wants to merge 1 commit into from

Conversation

achou11
Copy link
Member

@achou11 achou11 commented Sep 23, 2024

Adds a branch filter for any release-related branch so that the workflow runs more precisely.

https://optic.nearform.com/docs/github-action/examples#using-the-branches-filter

@achou11 achou11 requested a review from EvanHahn September 23, 2024 19:15
@gmaclennan
Copy link
Member

This filter is for the base branch of the PR (e.g. what you are merging into). Adding this filter would make this workflow also run if we made pull requests into a branch that matched release/**. We don't really do that, so not a huge issue, but nitpick: the change makes the workflow run "less precisely" rather than "more precisely" (it could be triggered in more circumstances)

@achou11
Copy link
Member Author

achou11 commented Sep 23, 2024

ah whoops - didn't realize it pointed to the branch that's being merged into - will close this then

@achou11 achou11 closed this Sep 23, 2024
@achou11 achou11 deleted the ac/release-workflow-branch-filter branch September 23, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants