Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused property from CoreManager #848

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

EvanHahn
Copy link
Contributor

@EvanHahn EvanHahn commented Sep 19, 2024

CoreManager was storing a #projectKey property which was never used. This removes it.

CoreManager was storing two properties, `#projectKey` and `#state`,
which were never used. This removes them.
Copy link
Member

@gmaclennan gmaclennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is the right fix for this, this is kind of a reminder that we should actually be using these properties to stop use of this class when it is closing or closed, and to stop errors when trying to close a second time while it is closing.

@EvanHahn EvanHahn removed the request for review from tomasciccola December 12, 2024 16:04
@EvanHahn EvanHahn changed the title chore: remove unused properties from CoreManager chore: remove unused property from CoreManager Dec 12, 2024
@EvanHahn
Copy link
Contributor Author

I updated this PR to keep one of the properties but remove one that was definitely still unused.

@EvanHahn EvanHahn enabled auto-merge (squash) December 12, 2024 16:52
@EvanHahn EvanHahn merged commit fc7a737 into main Dec 23, 2024
9 checks passed
@EvanHahn EvanHahn deleted the remove-unused-props-from-core-manager branch December 23, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants