-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: integrate npm-lockfile-changes action #846
Merged
Merged
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1b3f796
chore: integrate npm-lockfile-changes action
achou11 b66e1c4
attempt to fix error
achou11 959fcc5
try fork
achou11 353a3e6
add comment
achou11 4ced770
only run workflow if package-lock.json has changed
achou11 cb15fb7
Merge branch 'main' into ac/lockfile-changes-ci
achou11 6a77584
pin to specific commit
achou11 f9a0c06
use token generated via custom github app
achou11 db56e7d
Merge branch 'main' into ac/lockfile-changes-ci
achou11 efdaa12
Merge branch 'main' into ac/lockfile-changes-ci
achou11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,12 @@ | ||
name: Check Lockfile | ||
on: pull_request | ||
on: | ||
pull_request: | ||
paths: | ||
- 'package-lock.json' | ||
|
||
jobs: | ||
lockfile: | ||
name: Lockfile check | ||
lockfile_version: | ||
name: Lockfile version check | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Check out a copy of the repo | ||
|
@@ -11,3 +15,14 @@ jobs: | |
uses: mansona/npm-lockfile-version@v1 | ||
with: | ||
version: 3 | ||
lockfile_changes: | ||
name: Lockfile changes check | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Check out a copy of the repo | ||
uses: actions/checkout@v4 | ||
- name: NPM Lockfile Changes | ||
# The original doesn't support v3 lockfiles so we use a fork that adds support for them | ||
uses: rvanvelzen/npm-lockfile-changes@main | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For the sake of security, maybe pin to a specific commit? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. addressed via 6a77584 |
||
with: | ||
token: ${{ secrets.GITHUB_TOKEN }} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
highlighting this since it's kind of out of scope for the PR and could be reverted if not desired. Figured it would be worth doing to save a few CPU cycles though 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with including this.