chore!: update to latest schema version #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates `@mapeo/schema` to 3.0.0-next.27. I expect this to be the final version before `@comapeo/[email protected]`. This update required several changes: - Updating dev dependencies of `@mapeo/schema`: `@mapeo/mock-data` and `@mapeo/default-config`. - Removing unused `isInitialProject` from project settings. - Allowing translation `regionCode`s to be undefined (but not `null`). - Requiring `deviceType` on device info.
gmaclennan
approved these changes
Sep 16, 2024
| if (!languageCode) { | ||
| warnings.push(new Error(`invalid translation language ${lang}`)) | ||
| return | ||
| } | ||
| let { region: regionCode } = parsed | ||
| regionCode ||= undefined |
There was a problem hiding this comment.
nit: I assume this is to catch regionCode being null. This syntax is new/obscure enough that I think this warrants a comment, or changing to code to something more explicit like if (regionCode === null) regionCode = undefined
There was a problem hiding this comment.
It's to catch regionCode being falsy. '', null, and undefined should all be coerced to null.
This is because regionCode has to be between 2 and 3 characters when defined; the empty string is not valid.
achou11
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
@mapeo/schemato 3.0.0-next.27. I expect this to be the final version before@comapeo/[email protected].This update required several changes:
Updating dev dependencies of
@mapeo/schema:@mapeo/mock-dataand@mapeo/default-config.Removing unused
isInitialProjectfrom project settings.Allowing translation
regionCodes to be undefined (but notnull).Requiring
deviceTypeon device info.