Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: semver on release flow #823

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

tomasciccola
Copy link
Contributor

Since the idea is to follow semver, I've went ahead and only allowed (and uncommented) patch, minor and version on semver options. We may disagree with this and still have a prerelease (but I think we may not want this).
Also I commented some traces of prerelease related to naming the release on github and npm. If approve, I'll remove those commented lines

Copy link
Contributor

@EvanHahn EvanHahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I would personally keep prerelease stuff, but we can add it back as soon as we need it.

@tomasciccola
Copy link
Contributor Author

cool, then I'm leaving the commented lines there just in case we want to re-introduce some of this in the future

@tomasciccola tomasciccola merged commit 8781d03 into main Sep 11, 2024
7 checks passed
@tomasciccola tomasciccola deleted the chore/allowOnlySenverForReleaseFlows branch September 11, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants