iconFilenames should be Set<string>, not Set<string | undefined>
#790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasciccola
approved these changes
Aug 28, 2024
tomasciccola
merged commit aef3dee
into
fix/checkForMissingIconNameInConfigImport
7 checks passed
tomasciccola
added a commit
that referenced
this pull request
Aug 29, 2024
* check for icon file referenced by preset.icon * add access-point to completeConfig * add test for invalid icon name * remove unnecessary icons, fix presets.json * add icons to complete config * metter check for `'icon' in field` * compute `iconFilenames` once, repurpuse icon name regex * iconFilenames should be `Set<string>`, not `Set<string | undefined>` (#790) * Fix missing icon name, warn instead of throwing (#791) --------- Co-authored-by: Tomás Ciccola <[email protected]> Co-authored-by: Evan Hahn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.