chore: update hypercore-crypto to 3.4.2 #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates hypercore-crypto to its latest version. This project has no changelog but [perusing the commits][0] shows: - Sub-dependency upgrades - Minor security and performance improvements [0]: https://github.com/holepunchto/hypercore-crypto/commits/main
achou11
reviewed
Aug 26, 2024
| "sodium-universal": "^4.0.0" | ||
| "b4a": "^1.6.6", | ||
| "compact-encoding": "^2.15.0", | ||
| "sodium-universal": "^4.0.1" |
There was a problem hiding this comment.
wondering if them changing sodium-javascript to a peer dep affects us? maybe not at this level but at the app level?
There was a problem hiding this comment.
Hmm, not sure. I'll try to test this out when I get a chance.
There was a problem hiding this comment.
I thought we were now using sodium native in the app? If not, then we need to mark this as a breaking change with a note for the app team to install sodium-javascript.
There was a problem hiding this comment.
yeah we are, so probably not an issue for us specifically. still a subtle breaking change otherwise 😄
achou11
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates hypercore-crypto to its latest version.
This project has no changelog but perusing the commits shows: