Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: you can now leave a project if you're the only member #720

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

EvanHahn
Copy link
Contributor

Closes #717, which has more background on the motivation for this change.

Closes [#717], which has more background on the motivation for this
change.

[#717]: #717
@EvanHahn EvanHahn requested a review from achou11 July 22, 2024 14:48
Copy link
Member

@achou11 achou11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think the test named Creator cannot leave project if no other coordinators exist should be renamed so that it's clear that it's referring to when there are multiple project members. Currently sounds a little conflicting with the feature you're adding here (when it's actually not)

@EvanHahn
Copy link
Contributor Author

Changed the title in 06488d4. I'll merge if CI passes.

@EvanHahn EvanHahn merged commit b62a064 into main Jul 23, 2024
6 of 7 checks passed
@EvanHahn EvanHahn deleted the evanhahn/only-leaver branch July 23, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User cannot leave project as the only device
2 participants