test: move CoreSyncState tests to node:test
#648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test-only change drops Brittle from our CoreSyncState tests and replaces them with `node:test` and `node:assert`.
achou11
approved these changes
May 16, 2024
tests/sync/core-sync-state.js
Outdated
| } | ||
| }) | ||
|
|
||
| // This takes several hours to run on my M2 Macbook Pro (it's the slowBitCount | ||
| // that takes a long time - bitCount32 takes about 23 seconds), so not running | ||
| // this by default. The test did pass when I ran it though. | ||
| test.skip('bitCount32 (full test)', (t) => { | ||
| test('bitCount32 (full test)', { skip: true }, () => { |
There was a problem hiding this comment.
is using the opt instead of test.skip a preference? I have no strong preference, just wanted to make sure I'm not missing some subtle difference
There was a problem hiding this comment.
They're no different according to the docs. Not sure why I changed it. Reverted it in 0e34b32.
No different, just reduces the size of the diff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test-only change drops Brittle from our CoreSyncState tests and
replaces them with
node:testandnode:assert.