test: move FastifyController tests to node:test
#643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_I recommend reviewing this with whitespace changes disabled._ This test-only change drops Brittle from our FastifyController tests and replaces them with `node:test` and `node:assert`.
achou11
requested changes
May 16, 2024
This updates dot-prop to its latest version, v9.0.0. The only breaking change in [the release notes][0] doesn't affect us: Node 18+ is now required. [0]: https://github.com/sindresorhus/dot-prop/releases/tag/v9.0.0
ignore docs folder for linting and prettier Co-authored-by: Tomás Ciccola <[email protected]>
This test-only change drops Brittle from our Fastify plugin tests and replaces them with `node:test` and `node:assert`.
This test-only change drops Brittle from our CoreSyncState tests and replaces them with `node:test` and `node:assert`.
|
Not sure why there are so many commits listed here (I probably messed up a merge), but I'll squash before merging. |
achou11
approved these changes
May 16, 2024
EvanHahn
added a commit
that referenced
this pull request
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recommend reviewing this with whitespace changes disabled.
This test-only change drops Brittle from our FastifyController tests and replaces them with
node:testandnode:assert.