chore: simplify SyncApi "is syncing" logic
#610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change should have no impact. `SyncApi` needs to know whether sync is enabled. Currently, it does this in a roundabout way: appending a value to a set and checking for that value. This change replaces that with a simpler boolean flag.
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should have no impact.
SyncApineeds to know whether sync is enabled. Currently, it does this in a roundabout way: appending a value to a set and checking for that value.This change replaces that with a simpler boolean flag.
I think this is a useful change on its own, but it'll be useful as part of #576 too.