chore: testing improvements #552
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes several test-only improvements: - `prettier --check` should be run. (I had to reconfigure Prettier a bit, and format `CHANGELOG.md`.) - ESLint should be run with the `--cache` option. - Test code should be run in parallel, for performance. - `lint-staged` should run Prettier on all files, not just some extensions. - `lint-staged` should only check files, not fix them. This addresses a race condition (search [lint-staged's docs for "race condition"][0]). [0]: https://www.npmjs.com/package/lint-staged
|
Made a mistake here. I also think it's better to split this into smaller PRs, which I'll do now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes several test-only improvements:
prettier --checkshould be run. (I had to reconfigure Prettier a bit, and formatCHANGELOG.md.)ESLint should be run with the
--cacheoption.Test code should be run in parallel, for performance.⚠️ This is controversial!
lint-stagedshould run Prettier on all files, not just some extensions.lint-stagedshould only check files, not fix them. This addresses arace condition (search lint-staged's docs for "race condition").