chore!: remove "already part of project" invite response #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For simplicity, we decided to remove the "ALREADY" invite response and use "REJECT" in its place. We can add it back in the future if needed, but this makes the code simpler on the front-end and back-end.
|
How will the inviter know though without it? Do you plan to add a "reason" field to the reject response? I think we need to maintain the user experience for the inviter of knowing when inviting a device that it has "succeeded", in that they are part of the project. |
|
Erik and I discussed removing this for simplicity. There wouldn't be a way for users to differentiate between "invite rejected" and "user was already in the project". If it's important to keep for the MVP, I can close this PR and make sure it's kept. |
|
After some discussion, we decided to abandon this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For simplicity, we decided to remove the "ALREADY" invite response and use "REJECT" in its place. We can add it back in the future if needed, but this makes the code simpler on the front-end and back-end.