Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: mapeoProject.importConfig #405
Feat: mapeoProject.importConfig #405
Changes from 1 commit
2feae41
86c9b91
7dd8abd
0fd026e
b79198b
17e34e0
ee183cd
5a7ff4f
8246a18
e384251
9395c85
131697b
9c186c3
3d52628
5836fbd
1f5d870
cdf2f6f
e3aa86a
529e303
30cc84d
3ab89e7
d8f7d75
b1a7a58
8e31ab0
c5dab4f
8e8da77
5f59e82
4067976
526a9a1
f3313b4
f72c244
a0c04be
7acf998
118bc55
49ca3df
00d9bba
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it make sense to do this here instead of moving it outside to a function in
src/config-imprort.js
? I left it here since we are using a couple of methods of the class and it felt weird passing them to the function as params...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with it here. Could also add a
deleteAll()
method toDataType
or we could do a quick helper: