Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update @mapeo/sqlite-indexer #342

Closed
wants to merge 1 commit into from

Conversation

achou11
Copy link
Member

@achou11 achou11 commented Oct 19, 2023

Upgrades @mapeo/sqlite-indexer from 1.0.0-alpha.6 to 1.0.0-alpha.7

Not sure if anyone is aware of any tests that would benefit from being updated as a result of this change.

Upgrades @mapeo/sqlite-indexer from 1.0.0-alpha.6 to 1.0.0-alpha.7
@gmaclennan
Copy link
Member

Actually I seeing this made me realize that we should revert the change in @mapeo/sqlite-indexer, because deleted is not related to indexing, and the fact that the deletion tests work fine without this being updated shows it's not necessary. Therefore updating this dep is not necessary, since we will revert and release alpha.8 which will be the same as alpha.6. Separately, we should pin alpha deps - I did not realize that npm would resolve alpha deps to the latest alpha by default (that is why we are getting an error when using the published version of @mapeo/core)

@gmaclennan gmaclennan closed this Oct 20, 2023
@achou11 achou11 deleted the chore/update-sqlite-indexer branch October 20, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants