Code

Feat: IconApi#335

Code

Merged

achou11 merged 36 commits intomaindigidem/comapeo-core:mainfrom feat/IconApidigidem/comapeo-core:feat/IconApiCopy head branch name to clipboardNov 7, 2023

+928

Commits

Commits on Oct 9, 2023

• add initial Implementation of dataStore.writeRaw

  

  Tomás Ciccola

  committed
  bef3c5c

  Copy full SHA for bef3c5c

• add dataStore.readRaw and test

  

  Tomás Ciccola

  committed
  a3b80b5

  Copy full SHA for a3b80b5

• remove swap16 to avoid linting errors

  

  Tomás Ciccola

  committed
  6169575

  Copy full SHA for 6169575

• add IconApi class

  

  Tomás Ciccola

  committed
  1fb8482

  Copy full SHA for 1fb8482

• remove unused var, ignore ts error to make stuff work

  

  Tomás Ciccola

  committed
  2a4e65c

  Copy full SHA for 2a4e65c

• add check for invalid variants array, add test

  

  Tomás Ciccola

  committed
  a7460b1

  Copy full SHA for a7460b1

• change readRaw error to 'core not found'

  

  Tomás Ciccola

  committed
  eb424a5

  Copy full SHA for eb424a5

• Merge branch 'feat/dataStore.writeRaw' of github.com:digidem/mapeo-core-next into feat/IconApi

  

  Tomás Ciccola

  committed
  70c8f8a

  Copy full SHA for 70c8f8a

• Trying to make tests work

  Show description for cbee371
  

  Tomás Ciccola

  committed
  cbee371

  Copy full SHA for cbee371

• Merge branch 'main' of github.com:digidem/mapeo-core-next into feat/IconApi

  

  Tomás Ciccola

  committed
  7c19937

  Copy full SHA for 7c19937

Commits on Oct 10, 2023

• update mapeo-schema, make tests work

  

  Tomás Ciccola

  committed
  274abcd

  Copy full SHA for 274abcd

• implement getBestVariant

  Show description for 84bba41
  

  Tomás Ciccola

  committed
  84bba41

  Copy full SHA for 84bba41

• more tests, fix implementation to actually choose last with best score

  

  Tomás Ciccola

  committed
  b1022af

  Copy full SHA for b1022af

• return mimeType along icon in iconApi.getIcon

  

  Tomás Ciccola

  committed
  16a350a

  Copy full SHA for 16a350a

• fix tests

  

  Tomás Ciccola

  committed
  87072f2

  Copy full SHA for 87072f2

Commits on Oct 20, 2023

• various stuff:

  Show description for 4293a86
  

  Tomás Ciccola

  committed
  4293a86

  Copy full SHA for 4293a86

• in case of tie, choose first best score, comment failing test

  

  Tomás Ciccola

  committed
  00b9381

  Copy full SHA for 00b9381

• add test to getIconUrl

  

  Tomás Ciccola

  committed
  285565f

  Copy full SHA for 285565f

Commits on Oct 25, 2023

• added tests to find best variant, finished findBestVariant impl

  

  Tomás Ciccola

  committed
  8d41e3a

  Copy full SHA for 8d41e3a

• Merge branch 'main' of github.com:digidem/mapeo-core-next into feat/IconApi

  

  Tomás Ciccola

  committed
  466f7ff

  Copy full SHA for 466f7ff

Commits on Oct 26, 2023

• Various stuff:

  Show description for 0d089e5
  

  Tomás Ciccola

  committed
  0d089e5

  Copy full SHA for 0d089e5

• Merge branch 'main' of github.com:digidem/mapeo-core-next into feat/IconApi

  

  Tomás Ciccola

  committed
  b6eedc2

  Copy full SHA for b6eedc2

• Merge branch 'main' into feat/IconApi

  achou11

  committed
  6ec534d

  Copy full SHA for 6ec534d

Commits on Oct 30, 2023

• add more extensive tests for getBestVariant

  achou11

  committed
  34551a2

  Copy full SHA for 34551a2

• get new tests passing

  achou11

  committed
  5a39fe7

  Copy full SHA for 5a39fe7

Commits on Oct 31, 2023

• use discriminate union based on mime type for getBestVariant() opts

  achou11

  committed
  2a866d1

  Copy full SHA for 2a866d1

• avoid using ts-expect-error in tests

  achou11

  committed
  6a68388

  Copy full SHA for 6a68388

• add a couple of more tests (skipping one of them)

  achou11

  committed
  76eeb5c

  Copy full SHA for 76eeb5c

• clean up getBestVariant() implementation

  achou11

  committed
  75f7d77

  Copy full SHA for 75f7d77

• update getIconUrl implementation

  achou11

  committed
  8f68124

  Copy full SHA for 8f68124

• do a setup for each test

  achou11

  committed
  fe37d06

  Copy full SHA for fe37d06

• update create() to use discriminate union for variants param

  achou11

  committed
  a210782

  Copy full SHA for a210782

• update return types and clean up tests

  achou11

  committed
  a263200

  Copy full SHA for a263200

• add 'x' after pixel density in getIconUrl()

  achou11

  committed
  45438d7

  Copy full SHA for 45438d7

• Merge branch 'main' into feat/IconApi

  achou11

  committed
  a08c420

  Copy full SHA for a08c420

Commits on Nov 1, 2023

• add getMediaBaseUrl constructor opt and update getIconUrl()

  achou11

  committed
  c972987

  Copy full SHA for c972987