feat: add capabilities #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmaclennan
force-pushed
the
feat/core-ownership-writes
branch
from
8b647a1 to
f7b5703
Compare
gmaclennan
force-pushed
the
feat/capabilities
branch
2 times, most recently
from
d56f73a to
a591214
Compare
gmaclennan
force-pushed
the
feat/capabilities
branch
from
a591214 to
1777d8e
Compare
achou11
approved these changes
Aug 31, 2023
Comment on lines
+174
to
+175
| const isAssigningProjectCreatorRole = | ||
| authCoreId === this.#projectCreatorAuthCoreId |
There was a problem hiding this comment.
somewhat of a nit but initially read this as assigning a role called project creator
Suggested change
| const isAssigningProjectCreatorRole = | |
| authCoreId === this.#projectCreatorAuthCoreId | |
| const isAssigningToProjectCreator = | |
| authCoreId === this.#projectCreatorAuthCoreId |
| coreStorage: () => new RAM(), | ||
| }) | ||
| const ownDeviceId = km.getIdentityKeypair().publicKey.toString('hex') | ||
| console.log('deviceId', ownDeviceId.slice(0, 7)) |
| try { | ||
| const roleAssignment = await this.#dataType.getByDocId(deviceId) | ||
| roleId = roleAssignment.roleId | ||
| } catch (e) { |
There was a problem hiding this comment.
eslint doesn't complain about this being unused?
Suggested change
| } catch (e) { | |
| } catch { |
Comment on lines
+53
to
+58
| docs: mapObject(currentSchemaVersions, (key) => { | ||
| return [ | ||
| key, | ||
| { readOwn: true, writeOwn: true, readOthers: true, writeOthers: false }, | ||
| ] | ||
| }), |
There was a problem hiding this comment.
what's happening here with these object mappings? hard to tell at a glance without needing to dive into the currentSchemaVersions code
Closed
5 tasks
4 tasks
gmaclennan
added a commit
that referenced
this pull request
Sep 6, 2023
* main: (25 commits) add initial implementation of MemberApi (#232) feat: $blobs.getUrl and $blobs.create methods (#184) chore: update manager e2e tests (#237) feat: add capabilities (#231) feat: coreOwnership integration [3/3] (#230) feat: CoreOwnership class w getOwner & getCoreKey [2/3] (#229) feat: handle `coreOwnership` records in `IndexWriter` [1/3] (#214) fix: adjust storage options for MapeoManager and MapeoProject (#235) implement addProject method for MapeoManager class (#215) implement listProjects method for MapeoManager class (#208) feat: expose blobStore.writerDriveId (#219) implement wrapper client containing createProject and getProject methods (#199) add project settings functionality to MapeoProject (#187) feat: Add encode/decode for project keys [3/3] (#203) feat: update protobuf for RPC [2/3] (#202) chore: move protobuf messages into src/generated [1/3] (#201) feat: Add internal `dataType.createWithDocId()` (#192) chore: explicitly set "mode" opt for encryptionKeys column creation (#186) chore: fix linting and type checking (#183) chore: consolidate encryption key columns in projectKeys table (#181) ...
This was referenced Nov 16, 2023
This was referenced Apr 11, 2024
This was referenced Jun 20, 2024
This was referenced Aug 21, 2024
This was referenced Aug 29, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #189
More complete tests are blocked by the ability to invite and sync devices, tracking that in #238
This PR adds an internal
this.#capabilitiesinstance to the MapeoProject instance. It's initial use will be for assigning roles (part of the invite process) and for checking capabilities for sync when syncing with other devices. Checking capabilities for reading/writing mapeo docs is post-MVP. Also need to expose in the API, tracking that in #239Post-MVP we will implement the ability have custom roles and capabilities, but hard-coding is ok for now.