Skip to content

Commit

Permalink
chore: don't sync semver tags for releases (#921)
Browse files Browse the repository at this point in the history
The optic release option `sync-semver-tags` creates additional tags (`v{MAJOR}`, `v{MAJOR}.{MINOR}`) which are updated on each release. This currently does not work because this tag push happens with the permissions of the default github actions token, which does not have rule bypass permissions. It's a "soft fail" (the release still gets made), and the full version tag comes from the release creation, which is done by the optic release app, which is included in our ruleset bypass list.

We don't need these tags, and they are not working, so this PR turns this option off.
  • Loading branch information
gmaclennan authored Oct 21, 2024
1 parent 9e3c757 commit d3dc9d8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- uses: nearform-actions/optic-release-automation-action@v4
with:
commit-message: 'Release {version}'
sync-semver-tags: true
sync-semver-tags: false
access: 'public'
# This prefix is added before the prerelease number, e.g. `v3.0.0-alpha.0`
# prerelease-prefix: 'alpha'
Expand Down

0 comments on commit d3dc9d8

Please sign in to comment.