potentially naive attempt to fix pipe in BlobApi.writeFile()

src/blob-api.js

@@ -1,4 +1,5 @@
 import fs from 'node:fs'
+import { Transform } from 'node:stream'
 import { pipeline } from 'node:stream/promises'
 import { createHash } from 'node:crypto'
 import sodium from 'sodium-universal'
@@ -66,8 +67,8 @@ export class BlobApi {
         variant: 'original',
         type: blobType,
       },
-      metadata
-      // contentHash
+      metadata,
+      contentHash
     )
 
     if (preview) {
@@ -111,11 +112,14 @@ export class BlobApi {
    */
   async writeFile(filepath, { name, variant, type }, metadata, hash) {
     if (hash) {
-      // @ts-ignore TODO: return value types don't match pipeline's expectations, though they should
       await pipeline(
         fs.createReadStream(filepath),
-        hash,
-
+        new Transform({
+          transform: (data, _, cb) => {
+            hash.update(data)
+            cb(null, data)
+          },
+        }),
         // @ts-ignore TODO: remove driveId property from createWriteStream
         this.#blobStore.createWriteStream({ type, variant, name }, { metadata })
       )

tests/blob-api.js

@@ -24,6 +24,7 @@ test('create blobs', async (t) => {
 
   const hash = createHash('sha256')
   const originalContent = await fs.readFile(join(directory, 'original.png'))
+
   hash.update(originalContent)
 
   const attachment = await blobApi.create(
@@ -37,9 +38,7 @@ test('create blobs', async (t) => {
 
   t.is(attachment.driveId, blobStore.writerDriveId)
   t.is(attachment.type, 'photo')
-  // TODO: Need to fix BlobApi implementation
-  // https://github.com/digidem/mapeo-core-next/pull/365#pullrequestreview-1716846341
-  // t.alike(attachment.hash, hash.digest('hex'))
+  t.alike(attachment.hash, hash.digest('hex'))
 })
 
 test('get url from blobId', async (t) => {