Skip to content

Commit

Permalink
Remove unused events emitted by DataStore
Browse files Browse the repository at this point in the history
  • Loading branch information
gmaclennan committed Nov 27, 2023
1 parent 576b973 commit 4ed0928
Showing 1 changed file with 2 additions and 19 deletions.
21 changes: 2 additions & 19 deletions src/datastore/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,13 @@ import MultiCoreIndexer from 'multi-core-indexer'
import pDefer from 'p-defer'
import { discoveryKey } from 'hypercore-crypto'

/**
* @typedef {import('multi-core-indexer').IndexEvents} IndexEvents
*/
/**
* @typedef {import('@mapeo/schema').MapeoDoc} MapeoDoc
*/
/**
* @typedef {import('../datatype/index.js').MapeoDocTablesMap} MapeoDocTablesMap
*/
/**
* @typedef {object} DefaultEmitterEvents
* @property {(eventName: keyof IndexEvents, listener: (...args: any[]) => any) => void} newListener
* @property {(eventName: keyof IndexEvents, listener: (...args: any[]) => any) => void} removeListener
*/

/**
* @template T
* @template {keyof any} K
Expand All @@ -37,7 +30,7 @@ const NAMESPACE_SCHEMAS = /** @type {const} */ ({
/**
* @template {keyof NamespaceSchemas} [TNamespace=keyof NamespaceSchemas]
* @template {NamespaceSchemas[TNamespace][number]} [TSchemaName=NamespaceSchemas[TNamespace][number]]
* @extends {TypedEmitter<IndexEvents & DefaultEmitterEvents>}
* @extends {TypedEmitter}
*/
export class DataStore extends TypedEmitter {
#coreManager
Expand Down Expand Up @@ -72,16 +65,6 @@ export class DataStore extends TypedEmitter {
if (coreRecord.namespace !== namespace) return
this.#coreIndexer.addCore(coreRecord.core)
})

// Forward events from coreIndexer
this.on('newListener', (eventName, listener) => {
if (['newListener', 'removeListener'].includes(eventName)) return
this.#coreIndexer.on(eventName, listener)
})
this.on('removeListener', (eventName, listener) => {
if (['newListener', 'removeListener'].includes(eventName)) return
this.#coreIndexer.off(eventName, listener)
})
}

get indexer() {
Expand Down

0 comments on commit 4ed0928

Please sign in to comment.