Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Push PerCharacterEscaper #27

Merged
merged 7 commits into from
Mar 8, 2024
Merged

Push PerCharacterEscaper #27

merged 7 commits into from
Mar 8, 2024

Conversation

Trickybrain
Copy link
Collaborator

No description provided.

@Trickybrain Trickybrain marked this pull request as ready for review March 7, 2024 04:25
nedtwigg
nedtwigg reviewed Mar 7, 2024
View reviewed changes
Copy link
Member

@nedtwigg nedtwigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job that the tests are passing! Some style things to cleanup.

python/selfie-lib/selfie_lib/PerCharacterEscaper.py Outdated Show resolved Hide resolved
python/selfie-lib/selfie_lib/PerCharacterEscaper.py Outdated Show resolved Hide resolved
python/selfie-lib/selfie_lib/PerCharacterEscaper.py Outdated Show resolved Hide resolved
python/selfie-lib/tests/PerCharacterEscaper_test.py Outdated Show resolved Hide resolved
python/selfie-lib/tests/PerCharacterEscaper_test.py Outdated Show resolved Hide resolved
nedtwigg
nedtwigg suggested changes Mar 7, 2024
View reviewed changes
Copy link
Member

@nedtwigg nedtwigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, one last small change before it gets merged.

python/selfie-lib/selfie_lib/PerCharacterEscaper.py Outdated Show resolved Hide resolved
nedtwigg
nedtwigg suggested changes Mar 8, 2024
View reviewed changes
Copy link
Member

@nedtwigg nedtwigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last commit fixed an issue, but created a new one.

python/selfie-lib/selfie_lib/PerCharacterEscaper.py Outdated Show resolved Hide resolved
@nedtwigg
Copy link
Member

nedtwigg commented Mar 8, 2024

@nedtwigg nedtwigg merged commit 2aededc into diffplug:main Mar 8, 2024
2 checks passed
@Trickybrain Trickybrain deleted the PerCharacterEscaper-Edwin branch March 10, 2024 09:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nedtwigg nedtwigg nedtwigg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Trickybrain @nedtwigg