Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ieee_floatt::one(...) #8552

Merged
merged 1 commit into from
Jan 2, 2025
Merged

ieee_floatt::one(...) #8552

merged 1 commit into from
Jan 2, 2025

Conversation

kroening
Copy link
Member

@kroening kroening commented Jan 1, 2025

This adds ieee_floatt::one(...), as a convenience helper for generating an IEEE 754 number with the value one.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@kroening kroening changed the title ieee_floatt:one(...) ieee_floatt::one(...) Jan 1, 2025
@kroening kroening marked this pull request as ready for review January 1, 2025 19:38
Copy link

codecov bot commented Jan 1, 2025

Codecov Report

Attention: Patch coverage is 78.26087% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78.73%. Comparing base (6dc6dd5) to head (ebaf179).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
unit/util/ieee_float.cpp 50.00% 4 Missing ⚠️
src/goto-programs/interpreter_evaluate.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8552      +/-   ##
===========================================
- Coverage    78.93%   78.73%   -0.20%     
===========================================
  Files         1729     1730       +1     
  Lines       198762   199255     +493     
  Branches     18313    18312       -1     
===========================================
- Hits        156888   156886       -2     
- Misses       41874    42369     +495     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterschrammel peterschrammel removed their assignment Jan 2, 2025
@kroening kroening force-pushed the ieee_floatt_one branch 3 times, most recently from 2ea19e1 to 50df930 Compare January 2, 2025 10:49
This adds ieee_floatt::one(...), as a convenience helper for generating an
IEEE 754 number with the value one.
@kroening kroening enabled auto-merge January 2, 2025 12:23
@kroening kroening merged commit b3e9976 into develop Jan 2, 2025
37 of 41 checks passed
@kroening kroening deleted the ieee_floatt_one branch January 2, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants