Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KNOWNBUG test for enum-range check inside LHS of an assignment #8543

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

kroening
Copy link
Member

This adds a test that should fail an enum-range check inside the LHS of an assignment.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • n/a My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@kroening kroening force-pushed the enum_lhs branch 3 times, most recently from bfb5c39 to 51b35ac Compare December 23, 2024 17:53
85b90f3 has added a check that enum-typed
expressions correspond to one of the enum constants.

This adds a test that should fail an enum-range check inside the LHS of an
assignment.
kroening added a commit that referenced this pull request Dec 23, 2024
The check_rec recursion now distinguishes values that are assigned to,
enabling a fix of #8543.
kroening added a commit that referenced this pull request Dec 23, 2024
The check_rec recursion now distinguishes values that are assigned to,
enabling a fix of #8543.
@kroening kroening marked this pull request as ready for review December 23, 2024 18:26
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.55%. Comparing base (c4aaafd) to head (fbee5c1).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8543   +/-   ##
========================================
  Coverage    78.55%   78.55%           
========================================
  Files         1729     1729           
  Lines       199714   199714           
  Branches     18312    18312           
========================================
  Hits        156892   156892           
  Misses       42822    42822           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kroening added a commit that referenced this pull request Dec 24, 2024
The check_rec recursion now distinguishes values that are assigned to,
enabling a fix of #8543.
@tautschnig tautschnig merged commit b71084c into develop Dec 25, 2024
39 of 41 checks passed
@tautschnig tautschnig deleted the enum_lhs branch December 25, 2024 07:12
kroening added a commit that referenced this pull request Dec 25, 2024
The check_rec recursion now distinguishes values that are assigned to,
enabling a fix of #8543.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants