fix: clear deadlines after transition

diegosteiner · Dec 3, 2024 · 0fd35a4 · 0fd35a4
1 parent 390d59e
commit 0fd35a4
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 2 deletions.
diff --git a/app/controllers/manage/deadlines_controller.rb b/app/controllers/manage/deadlines_controller.rb
@@ -10,7 +10,7 @@ def edit
     end
 
     def update
-      @booking.set_deadline(deadline_params)
+      @booking.set_deadline(**deadline_params)
       respond_with :manage, @booking, location: manage_booking_path(@booking)
     end
 

diff --git a/app/domain/booking_states/overdue.rb b/app/domain/booking_states/overdue.rb
@@ -19,6 +19,7 @@ def self.to_sym
     end
 
     after_transition do |booking|
+      booking.deadline&.clear
       MailTemplate.use(:overdue_notification, booking, to: :tenant, &:autodeliver!)
     end
 

diff --git a/app/domain/booking_states/payment_overdue.rb b/app/domain/booking_states/payment_overdue.rb
@@ -19,6 +19,7 @@ def invoice_type
     end
 
     after_transition do |booking|
+      booking.deadline&.clear
       MailTemplate.use(:payment_overdue_notification, booking, to: :tenant, &:autodeliver!)
     end
 

diff --git a/app/models/booking.rb b/app/models/booking.rb
@@ -195,7 +195,7 @@ def editable?
     booking_state&.editable || false
   end
 
-  def set_deadline(params = {})
+  def set_deadline(**params)
     build_deadline if deadline.blank?
     deadline.update(armed: true, postponable_for: nil, **params, booking: self)
     deadline
-Original file line number
+Diff line change
@@ Expand Up / @@ -19,6 +19,7 @@ def self.to_sym @@
         end
         after_transition do |booking|
+          booking.deadline&.clear
           MailTemplate.use(:overdue_notification, booking, to: :tenant, &:autodeliver!)
         end
@@ Expand Down @@