Merge pull request #749 from liz3/liz3/utf8-experiments

utf-8 support in strings

src/cli/CMakeLists.txt

@@ -9,3 +9,7 @@ add_compile_definitions(USE_UTF8)
 add_executable(dictu ${DICTU_CLI_SRC})
 target_include_directories(dictu PUBLIC ${INCLUDE_DIR})
 target_link_libraries(dictu dictu_api_static)
+if(LINUX AND CMAKE_C_COMPILER_ID STREQUAL "Clang")
+    # Clang needs this otherwise ld will fail on linux since the lib is build with -flto
+    set(CMAKE_C_FLAGS_RELEASE "-flto")
+endif()

src/optionals/sqlite/sqlite3.c

@@ -56382,7 +56382,7 @@ SQLITE_PRIVATE int sqlite3PagerOpen(
   const char *zUri = 0;    /* URI args to copy */
   int nUriByte = 1;        /* Number of bytes of URI args at *zUri */
   int nUri = 0;            /* Number of URI parameters */
-
+  (void)nUri;
   /* Figure out how much space is required for each journal file-handle
   ** (there are two of them, the main journal and the sub-journal).  */
   journalFileSize = ROUND8(sqlite3JournalSize(pVfs));

src/optionals/uuid.c

@@ -3,7 +3,9 @@
 #ifndef _WIN32
 static uuid_t uuid;
 
-#define UUID_STRING_LEN 37
+#define UUID_STRING_LEN 36 // Note(Liz3): the strlen() of a UUID is 36, but the uuid_unparse_lower call expects
+                           // a buffer with space for the null byte, but since copyString wants the strlen we
+                           // keep the define to 36 and allocate +1.
 
 static Value uuidGenerateNative(DictuVM *vm, int argCount, Value *args) {
     UNUSED(args);
@@ -21,7 +23,7 @@ static Value uuidGenerateNative(DictuVM *vm, int argCount, Value *args) {
         return newResultError(vm, "error: failed to generate uuid");
     }
 
-    char out[UUID_STRING_LEN] = {};
+    char out[UUID_STRING_LEN+1] = {};
     uuid_unparse_lower(uuid, out);
 
     return newResultSuccess(vm, OBJ_VAL(copyString(vm, out, UUID_STRING_LEN)));
@@ -43,7 +45,7 @@ static Value uuidGenRandomNative(DictuVM *vm, int argCount, Value *args) {
         return newResultError(vm, "error: failed to generate uuid");
     }
 
-    char out[UUID_STRING_LEN] = {};
+    char out[UUID_STRING_LEN+1] = {};
     uuid_unparse_lower(uuid, out);
 
     return newResultSuccess(vm, OBJ_VAL(copyString(vm, out, UUID_STRING_LEN)));
@@ -65,7 +67,7 @@ static Value uuidGenTimeNative(DictuVM *vm, int argCount, Value *args) {
         return newResultError(vm, "error: failed to generate uuid");
     }
 
-    char out[UUID_STRING_LEN] = {};
+    char out[UUID_STRING_LEN+1] = {};
     uuid_unparse_lower(uuid, out);
 
     return newResultSuccess(vm, OBJ_VAL(copyString(vm, out, UUID_STRING_LEN)));