improve Dhall.Map.traverseWithKey performance #2589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traverseWithKey currently calls fromList, which creates a new list of keys (and calls nubOrd on it). this is unnecessary, because a traversal doesn't change the keys.
|
Currently the macos build seems to be broken. I've been trying randomly poking around to fix it but I don't really know what I'm doing in this build system. #2586 Anyone has any ideas? The failure is around |
|
Thank you @winitzki! |
Gabriella439
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
traverseWithKeycurrently callsfromList, which creates a new list of keys (and callsnubOrdon it). this is unnecessary, because a traversal doesn't change the keys.I haven't done any benchmarking of
traverseWithKeyspecifically, but this change reduces my overall parse+typecheck+inject+normalize+extract time by ~20%.