Simplify type bounds on Setting, not always Eq
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes `swash::Setting` more like `skrifa::setting::Setting`. It is only `Eq` when the underlying type is `Eq`, so not for `Setting<f32>`. It doesn't need to always state that it is `Copy`, so only state that when needed. The impl of `PartialEq` can be derived.
xStrom
approved these changes
Dec 7, 2024
|
FWIW, this is related to linebender/parley#206 |
dfrg
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
swash::Settingmore likeskrifa::setting::Setting.It is only
Eqwhen the underlying type isEq, so not forSetting<f32>.It doesn't need to always state that it is
Copy, so only state that when needed.The impl of
PartialEqcan be derived.