-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for no_std
#63
Conversation
If this lands, I can revise #61 to deal with |
I should add a lot of CI to this repo, including for |
8d78f06
to
e6b154d
Compare
Added a check for I didn't use a 32 bit target because the one I chose didn't work due to not having an |
I think it'll be best if #61 lands first and then I'll revise this some to support |
Swash not having |
e6b154d
to
37b1f9d
Compare
@dfrg I've updated this PR to not have merge conflicts ... it gives |
See #69 |
oops, I seem to have merged these in the wrong order causing a merge conflict (did the dep updates first) |
When I am awake today, I will update this so that it is fully no_std now that the deps update landed. |
37b1f9d
to
004145f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no_std
support has been a much requested feature since this crate was released and I really appreciate the work to get it done.
LGTM
004145f
to
f37dd86
Compare
Done. I was distracted by trying to fix Zeno's CI and wasn't looking at emails. |
To really get no-std support in parley, we need to land dfrg/swash#63. But I believe I've done everything else that's necessary, in both parley and fontique. One can test the build by patching Cargo.toml to use the working branch for that swash PR, and modifying parley/Cargo.toml to specify swash/std or swash/libm as appropriate. If we decide to land dfrg/swash#63 before landing this one, then I can make the latter modification to parley/Cargo.toml before merging this PR. Some of my changes, e.g. unconditionally using `alloc::vec::Vec`, are designed to minimize the amount of noise when searching the whole source tree for "std".
This doesn't support the
scale
orrender
features yet as that needs an update tozeno
andyazi
.