Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(IDX): reuse check-membership workflow #102

Merged
merged 6 commits into from
Jan 27, 2025
Merged

feat(IDX): reuse check-membership workflow #102

merged 6 commits into from
Jan 27, 2025

Conversation

cgundy
Copy link
Member

@cgundy cgundy commented Jan 27, 2025

Since we use the same workflow twice, it's better to have it in a single file and call it to make updates easier.

@cgundy cgundy marked this pull request as ready for review January 27, 2025 12:42
@cgundy cgundy requested a review from a team as a code owner January 27, 2025 12:42
basvandijk
basvandijk approved these changes Jan 27, 2025
View reviewed changes
.github/workflows/check_cla.yml Outdated Show resolved Hide resolved
@cgundy cgundy merged commit f5f67a6 into main Jan 27, 2025
7 checks passed
@cgundy cgundy deleted the create-check-membership-composite-action branch January 27, 2025 13:23
cgundy added a commit that referenced this pull request Jan 27, 2025
@cgundy
Revert "feat(IDX): reuse check-membership workflow (#102)"
7178182 
This reverts commit f5f67a6.
@cgundy cgundy mentioned this pull request Jan 27, 2025
Merged
cgundy added a commit that referenced this pull request Jan 27, 2025
@cgundy
Revert "feat(IDX): reuse check-membership workflow (#102)" (#103)
ff8baea 
This reverts commit f5f67a6.
cgundy added a commit that referenced this pull request Jan 27, 2025
@cgundy
Revert "Revert "feat(IDX): reuse check-membership workflow (#102)" (#103
d39c776 
)"

This reverts commit ff8baea.
cgundy added a commit that referenced this pull request Jan 27, 2025
@cgundy
feat(IDX): reuse check-membership workflow (#104)
29416e2 
* Revert "Revert "feat(IDX): reuse check-membership workflow (#102)" (#103)"

This reverts commit ff8baea.

* Update check_cla_ruleset.yml

* Update check_cla.yml

* Update internal_vs_external.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk basvandijk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgundy @basvandijk