Don't show dialog on device rename (#1594)

This removes the prompt when the user decides to rename a device. The prompt was simply confusing.
dfinity · May 12, 2023 · c1c1074 · c1c1074
1 parent 927809c
commit c1c1074
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 7 deletions.
diff --git a/src/frontend/src/flows/manage/deviceSettings.ts b/src/frontend/src/flows/manage/deviceSettings.ts
@@ -27,11 +27,6 @@ export const renameDevice = async ({
   device: DeviceData;
   reload: () => void;
 }) => {
-  const confirmed = confirm("Choose a nickname for this passkey.");
-  if (!confirmed) {
-    return;
-  }
-
   const alias = await promptDeviceAlias({
     title: "Passkey Nickname",
     message: "Choose a nickname for this Passkey",

diff --git a/src/frontend/src/test-e2e/views.ts b/src/frontend/src/test-e2e/views.ts
@@ -239,8 +239,6 @@ export class MainView extends View {
     await this.browser
       .$(`button[data-device="${deviceName}"][data-action='rename']`)
       .click();
-    await this.browser.waitUntil(this.browser.isAlertOpen);
-    await this.browser.acceptAlert();
 
     const renameView = new RenameView(this.browser);
     await renameView.waitForDisplay();