feat(MR): [MR-649] Support incremental rollout of best-effort calls #3688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the on-off flag with an enum of 4 progressive rollout stages: * Stage 0: Trap on related API calls; and reject best-effort requests when routing (status quo). * Stage 1: Silently ignore `ic0_call_with_best_effort_response()` calls, falling back to guaranteed response calls; and reject best-effort requests when routing. * Stage 2: On system subnets, silently ignore `ic0_call_with_best_effort_response()` calls, falling back to guaranteed response calls; and reject best-effort requests that should be routed to system subnets. * Stage 3: Fully enable API calls; always route best-effort requests. Rollbacks (incremental or direct) are also supported, but it's probably a bad idea to roll back to stage 0, as any canisters already using best-effort calls would break. Badly.
alin-at-dfinity
requested review from
stiegerc,
derlerd-dfinity and
oggy-dfin
stiegerc
reviewed
Jan 30, 2025
Co-authored-by: stiegerc <[email protected]>
adambratschikaye
approved these changes
Jan 30, 2025
alin-at-dfinity
commented
Jan 30, 2025
eichhorl
approved these changes
Jan 30, 2025
…e rolling out to specific subnets only.
derlerd-dfinity
approved these changes
Feb 6, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
stiegerc
approved these changes
Feb 7, 2025
alin-at-dfinity
deleted the
alin/MR-649-no-best-effort-calls-to-system-subnets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the on-off flag with an enum of 4 progressive rollout stages:
ic0_call_with_best_effort_response()calls, falling back to guaranteed response calls; and reject best-effort requests when routing.ic0_call_with_best_effort_response()calls, falling back to guaranteed response calls; and reject best-effort requests that should be routed to subnets other than the selected ones.ic0_call_with_best_effort_response()calls, falling back to guaranteed response calls; and reject best-effort requests that should be routed to system subnets.Rollbacks (incremental or direct) are also supported, including all the way to Stage 1a. In case of a rollback, not-yet-routed best-effort requests will be rejected; already existing best-effort callbacks will expire when appropriate, as per their deadlines; and best-effort responses will be delivered (unless they expire on the way).