refactor(nns-governance): Delete *_voting_power fields from governance.proto. #3643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-wong-dfinity-org
changed the base branch from
master
to
delete-neuron-info-from-governance-proto-daniel-wong
Base automatically changed from
delete-neuron-info-from-governance-proto-daniel-wong
to
master
January 28, 2025 12:46
daniel-wong-dfinity-org
force-pushed
the
delete-voting-power-fields-from-governance-proto-daniel-wong
branch
10 times, most recently
from
8fe714c to
be7b682
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).
To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:
-
Done.
-
No canister behavior changes.
daniel-wong-dfinity-org
dismissed
github-actions[bot]’s stale review
No canister behavior change. Just a refactor.
rs/nns/governance/proto/ic_nns_governance/pb/v1/governance.proto
Outdated
Show resolved
Hide resolved
max-dfinity
reviewed
Jan 29, 2025
max-dfinity
approved these changes
Jan 30, 2025
…overnance.proto. These are derived, and therefore, do not need to be stored in stable memory. They are part of the API though, so we do not remove them from governance.did.
…information is needed to perform this conversion. Specifically, in order to populate the deciding_voting_power field, VotingPowerEconomics is needed. Also deleted transcribing from *_voting_power fields in the other direction.
…ecause we deleted that in a recent commit. Resurrected `impl From<Neuron> for NeuronProto`, which replaces `into_proto`, which is no longer needed, because converting to NeuronProto no longer requires auxiliary data (used to calculate *_voting_power fields that have been deleted). Still need to implement convertion to API Neuron. That will be done in next commit. //rs/nns/governance builds 🤘
…fix affected tests, it was simply a matter of instead using pb::Neuron::from.
…ing *_voting_power fields from NNS governance.proto).
…ng, which (again, IMHO) is per usual.
daniel-wong-dfinity-org
force-pushed
the
delete-voting-power-fields-from-governance-proto-daniel-wong
branch
from
620d9fe to
b3649d5
Compare
daniel-wong-dfinity-org
deleted the
delete-voting-power-fields-from-governance-proto-daniel-wong
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale/Motivation
These values are derived. Hence, they do not need to be and should not be stored.
Overview
Got rid of
into_proto.Reintroduced
pb::Neuron::from.Added
into_api.Depending on the situation,
into_protocalls were replaced with eitherpb::Neuron::fromorinto_api. The difference is that the former is easier (requires less inputs), but the latter provides (deciding|potential)_voting_power.References
Closes NNS1-3500.