feat(MR): [MR-638] Use both guaranteed and best-effort calls in all XNet tests #3582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A straightforward XNet test using best-effort calls.
…test Make both guaranteed response and best-effort calls in the subnet upgrade-downgrade `xnet_compatibility` test.
…Net tests Default to a mix of guaranteed response and best-effort calls in all tests involving the `xnet_test_canister` (except for `test_response_in_output_queue_causes_backpressure`, which expects messages not to time out for 24 hours; and, for now, `xnet_compatibility`, since mainnet does not yet allow best-effort calls).
alin-at-dfinity
requested review from
stiegerc,
derlerd-dfinity and
oggy-dfin
|
This is an alternative to #3531 that switches all tests involving |
stiegerc
reviewed
Jan 24, 2025
alin-at-dfinity
force-pushed
the
alin/MR-638-best-effort-xnet-tests
branch
from
2026ed0 to
d54f5e3
Compare
derlerd-dfinity
approved these changes
Feb 7, 2025
This was referenced Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default to a mix of guaranteed response and best-effort calls in all tests involving the
xnet_test_canister(except fortest_response_in_output_queue_causes_backpressure, which expects messages not to time out for 24 hours; and, for now,xnet_compatibility, since mainnet does not yet allow best-effort calls).