Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(crypto): CRP-2599 implement VetKdProtocol trait for CryptoComponent #3565

Merged
merged 31 commits into from
Jan 31, 2025
Merged

feat(crypto): CRP-2599 implement VetKdProtocol trait for CryptoComponent #3565

merged 31 commits into from
Jan 31, 2025

Conversation

fspreiss
Copy link
Member

@fspreiss fspreiss commented Jan 22, 2025 •
edited
Loading

Implements the VetKdProtocol trait for the CryptoComponent

Smoke tests are added in #3649. They are split from this PR to make the PR review easier.

@github-actions github-actions bot added the feat label Jan 22, 2025
Base automatically changed from jack/crp-2648 to master January 27, 2025 15:18
@fspreiss fspreiss mentioned this pull request Jan 28, 2025
Merged
@fspreiss fspreiss marked this pull request as ready for review January 28, 2025 13:21
@fspreiss fspreiss requested review from a team as code owners January 28, 2025 13:21
eichhorl
eichhorl reviewed Jan 29, 2025
View reviewed changes
rs/interfaces/src/crypto/errors.rs Outdated Show resolved Hide resolved
rs/crypto/src/vetkd/mod.rs Show resolved Hide resolved
randombit
randombit approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@randombit randombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just left some minor comments/suggestions

rs/crypto/src/vetkd/mod.rs Outdated Show resolved Hide resolved
rs/crypto/src/vetkd/mod.rs Outdated Show resolved Hide resolved
rs/crypto/src/vetkd/mod.rs Outdated Show resolved Hide resolved
rs/crypto/src/vetkd/mod.rs Outdated Show resolved Hide resolved
altkdf
altkdf approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@altkdf altkdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't look very closely at the low-level details, but overall LGTM!

@fspreiss fspreiss added this pull request to the merge queue Jan 31, 2025
Merged via the queue into master with commit 15a5164 Jan 31, 2025
25 checks passed
@fspreiss fspreiss deleted the franzstefan/CRP-2599-vetkdprotocol-impl branch January 31, 2025 10:50
github-merge-queue bot pushed a commit that referenced this pull request Jan 31, 2025
@fspreiss @randombit
test(crypto): CRP-2599 add smoke test for VetKdProtocol impl (#3649)
61639ea 
Adds smoke tests for the VetKdProtocol trait implementation added in
#3565

---------

Co-authored-by: Jack Lloyd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eichhorl eichhorl eichhorl left review comments

@altkdf altkdf altkdf approved these changes

@yvonneanne yvonneanne yvonneanne approved these changes

@randombit randombit randombit approved these changes

Assignees
No one assigned
Labels
@crypto-team feat @ic-interface-owners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fspreiss @randombit @yvonneanne @eichhorl @altkdf