fix: EXC-1815: Fix sandbox processes metric #3527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The monitoring thread may collect information about each sandbox process for a few seconds. Consequently, metrics scraping might occur during this collection phase, leading to an underreporting of the number of sandboxes. This PR addresses this issue by: 1. Collecting metrics into small vectors of `f64`` values. This allows for more efficient and consistent data gathering. 2. Observing the metrics within a tight loop. This ensures that the latest and most accurate data is captured. While this approach may not completely eliminate the possibility of an incomplete sandbox count, it should significantly reduce the likelihood of this occurring.
dsarlis
approved these changes
Jan 21, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The monitoring thread may collect information about each sandbox process for a few seconds. Consequently, metrics scraping might occur during this collection phase, leading to an underreporting of the number of sandboxes.
This PR addresses this issue by:
f64values. This allows for more efficient and consistent data gathering.While this approach may not completely eliminate the possibility of an incomplete sandbox count, it should significantly reduce the likelihood of this occurring.