fix: EXC-1765: Fix canister_age metric
#3443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berestovskyy
changed the title
canister_age metriccanister_age metric
dsarlis
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
The scheduler_canister_age_rounds metric tracks the difference between the current round and the round in which the canister last fully executed. By default, this last executed round is set to zero for newly created canisters. Consequently, the canister_age metric for these new canisters abruptly increases to the current round, which can be in the billions.
This PR also increases the metric range up to 5000 rounds.
Did you perhaps forget to mention what is the actual fix to the problem described?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
scheduler_canister_age_roundsmetric tracks the difference between the current round and the round in which the canister last fully executed. By default, this last executed round is set to zero for newly created canisters. Consequently, thecanister_agemetric for these new canisters abruptly increases to the current round, which can be in the billions.This PR addresses this issue by excluding canisters with a zero 'last executed round' from the
canister_agemetric observations.Furthermore, this PR increases the upper bound of the metric's range to 5000 rounds.