chore(RUN-1012): infrastructure to increase Wasm64 heap memory size #3385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandru-uta
changed the title
alexandru-uta
commented
Jan 14, 2025
… and Wasm64; this info is propagated in the places where it is needed.
…when different values are set for Wasm32 vs Wasm64
luc-blaeser
approved these changes
Jan 20, 2025
michael-weigelt
approved these changes
Jan 20, 2025
schneiderstefan
approved these changes
Jan 20, 2025
dsarlis
approved these changes
Jan 20, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares infrastructure to increase Wasm64 heap memory size allowing Wasm64 canisters to run with different heap memory sizes alongside the Wasm32 canisters.
Note that this PR is a no-op for now and not changing any functionality, as the Wasm64 heap memory size is still kept at 4GiB. The intent is that this only allows that in the future the change can happen seamlessly, by only changing a constant.