fix(nns): Fix benchmark by simulating proper behavior in canbench-rs build #3160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-dfinity
force-pushed
the
msum/NNS1-3501
branch
from
3511aae to
da9b6cd
Compare
jasonz-dfinity
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to get approximately the same number of read/writes in stable for the VotingStateMachine, it is required to count accurately. Canbench doesn't allow queries, which means the instruction_counter never gives a different result, which means the benchmark thinks it runs out of cycles on every iteration, and thus saves and restores the ProposalVotingStateMachine over and over, leading to an inaccurate benchmark compared to production.
This adds code to approximately simulate behavior in canbench-rs build.